Skip to content

Supports hal_nxp of MCUX SDK 25.06.00 #93306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ZhaoxiangJin
Copy link
Contributor

Update hal nxp to mcux sdk 25.06.00.

Copy link

github-actions bot commented Jul 18, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@2de68b6 zephyrproject-rtos/hal_nxp#576 zephyrproject-rtos/hal_nxp#576/files

DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_nxp DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Jul 18, 2025
@ZhaoxiangJin ZhaoxiangJin reopened this Jul 18, 2025
@ZhaoxiangJin ZhaoxiangJin force-pushed the feature/test-hal-nxp-update branch from 3d12908 to 41f8800 Compare July 18, 2025 14:43
@ZhaoxiangJin ZhaoxiangJin reopened this Jul 21, 2025
@ZhaoxiangJin ZhaoxiangJin force-pushed the feature/test-hal-nxp-update branch 4 times, most recently from 9ff95b8 to 8ca95a8 Compare July 28, 2025 06:17
@ZhaoxiangJin ZhaoxiangJin force-pushed the feature/test-hal-nxp-update branch 3 times, most recently from e30e2a4 to 8a23c6a Compare July 30, 2025 06:24
@ZhaoxiangJin ZhaoxiangJin changed the title Update hal nxp to mcux sdk 25.06.00 Supports hal_nxp of MCUX SDK 25.06.00 Jul 30, 2025
@ZhaoxiangJin ZhaoxiangJin marked this pull request as ready for review July 30, 2025 07:47
Comment on lines 630 to 631
* :zephyr:board:`frdm_mcxa346` (``frdm_mcxa346``)
* :zephyr:board:`frdm_mcxa266` (``frdm_mcxa266``)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be renamed, board wasn't named like this at the time of the release. Just drop the zephyr:board: role I guess

Copy link
Contributor Author

@ZhaoxiangJin ZhaoxiangJin Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think this file should not be changed, but the CI will check the 'release-notes-4.2.rst' and report board not find issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZhaoxiangJin V4.2 is already released. If anything, this needs to be captured in the v4.3 release notes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dropped the change, the CI show failures on documentation build, I'd like to know why CI still builds release-notes-4.2.rst even though 4.2 has been released.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question.

@kartben this seems like a new case for us. The v4.2 release notes reference the previous board name and we are changing the name of the board. Is there some way to do an "alias" on the reference?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this PR forward? Many developers are waiting for the updated hal.

@kartben kartben assigned mmahadevan108 and dleach02 and unassigned kartben Jul 30, 2025
@ZhaoxiangJin ZhaoxiangJin force-pushed the feature/test-hal-nxp-update branch from 8a23c6a to cbc589f Compare August 1, 2025 08:52
@ZhaoxiangJin ZhaoxiangJin requested a review from kartben August 1, 2025 09:52
@ZhaoxiangJin ZhaoxiangJin force-pushed the feature/test-hal-nxp-update branch 2 times, most recently from 0a46dbd to c112334 Compare August 8, 2025 06:22
@ZhaoxiangJin
Copy link
Contributor Author

update:
fixed conflict

@zejiang0jason
Copy link
Contributor

Please move the board level files from hal_nxp subrepo to the board folder of this repo, such as the dcd.c. These files are board specific.

@zejiang0jason
Copy link
Contributor

The changes are split into several patches, do we need to merge the necessary patches, to make every snapshot buildable?

ZhaoxiangJin and others added 7 commits August 11, 2025 11:14
These variables are used to make MCUX SDK NG cmake
can find the right cmake files.

Signed-off-by: Zhaoxiang Jin <[email protected]>
'MCUX_HW_CORE' and 'MCUX_HW_FPU_TYPE' are used in
modules/hal_nxp/device.cmake. It is a variable used
by MCUX SDK CMake.

Signed-off-by: Zhaoxiang Jin <[email protected]>
Update hal_nxp to mcux sdk 25.06.00.

Signed-off-by: Zhaoxiang Jin <[email protected]>
Now use the 5-parameter function "PINT_PinInterruptConfig"
deprecated in MCUX SDK, need to add compile definition
'PINT_USE_LEGACY_CALBACK' to make intc_nxp_pint compatible
with updated 'fsl_pint' driver.

Signed-off-by: Zhaoxiang Jin <[email protected]>
1. Add core_id for RT685 HIFI4 core, this variable is
used in MCUX SDK cmake.
2. Set cmake variables 'CONFIG_MCUX_COMPONENT_driver.smartdma_mcxn'
and 'CONFIG_MCUX_COMPONENT_driver.smartdma_rt500' to "ON" as these
variables control the loading of source files in the latest driver
CMakeList.txt.

Signed-off-by: Zhaoxiang Jin <[email protected]>
1. Renamed MCXA166 to MCXA346.
2. NXP frdm_mcxa166 is renamed to frdm_mcxa346,
add this information to migration-guide-4.3.rst.

Signed-off-by: Zhaoxiang Jin <[email protected]>
1. Renamed MCXA276 to MCXA266
2. NXP frdm_mcxa276 is renamed to frdm_mcxa266,
add this information to migration-guide-4.3.rst.

Signed-off-by: Peter Wang <[email protected]>
@ZhaoxiangJin ZhaoxiangJin force-pushed the feature/test-hal-nxp-update branch from c112334 to 5c359d4 Compare August 11, 2025 05:34
@ZhaoxiangJin
Copy link
Contributor Author

Update:

  1. Move board specific files (dcd, flash_config, etc.) from nxp hal repo to zephyr repo.
  2. Removed frdm_mcxa166 and frdm_mcxa276 from release-notes-4.2.rst.

@ZhaoxiangJin ZhaoxiangJin marked this pull request as draft August 11, 2025 06:37
Move board specific files (dcd, flash_config, etc.) from
nxp hal repo to zephyr repo.

Signed-off-by: Zhaoxiang Jin <[email protected]>
@ZhaoxiangJin ZhaoxiangJin force-pushed the feature/test-hal-nxp-update branch from 5c359d4 to 9e64dd7 Compare August 11, 2025 07:09
Copy link

@dleach02
Copy link
Member

@ZhaoxiangJin please address the compliance failures

@ZhaoxiangJin
Copy link
Contributor Author

ZhaoxiangJin commented Aug 13, 2025

@ZhaoxiangJin please address the compliance failures

Fix is on going, but there are a lot of compliance issues that need to be resolved, I need more time to fix them...

@zejiang0jason
Copy link
Contributor

Hi @dleach02 , the compliance issue is because we are moving the board specific dcd.c, flexspi_nor_config.c to zephyr board folder. There are many coding style issue in these files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNM (manifest) This PR should not be merged (controlled by action-manifest) manifest manifest-hal_nxp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants