-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Supports hal_nxp of MCUX SDK 25.06.00 #93306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Supports hal_nxp of MCUX SDK 25.06.00 #93306
Conversation
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
3d12908
to
41f8800
Compare
9ff95b8
to
8ca95a8
Compare
e30e2a4
to
8a23c6a
Compare
doc/releases/release-notes-4.2.rst
Outdated
* :zephyr:board:`frdm_mcxa346` (``frdm_mcxa346``) | ||
* :zephyr:board:`frdm_mcxa266` (``frdm_mcxa266``) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be renamed, board wasn't named like this at the time of the release. Just drop the zephyr:board:
role I guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think this file should not be changed, but the CI will check the 'release-notes-4.2.rst' and report board not find issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZhaoxiangJin V4.2 is already released. If anything, this needs to be captured in the v4.3 release notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dropped the change, the CI show failures on documentation build, I'd like to know why CI still builds release-notes-4.2.rst even though 4.2 has been released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question.
@kartben this seems like a new case for us. The v4.2 release notes reference the previous board name and we are changing the name of the board. Is there some way to do an "alias" on the reference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this PR forward? Many developers are waiting for the updated hal.
8a23c6a
to
cbc589f
Compare
0a46dbd
to
c112334
Compare
update: |
Please move the board level files from hal_nxp subrepo to the board folder of this repo, such as the dcd.c. These files are board specific. |
The changes are split into several patches, do we need to merge the necessary patches, to make every snapshot buildable? |
These variables are used to make MCUX SDK NG cmake can find the right cmake files. Signed-off-by: Zhaoxiang Jin <[email protected]>
'MCUX_HW_CORE' and 'MCUX_HW_FPU_TYPE' are used in modules/hal_nxp/device.cmake. It is a variable used by MCUX SDK CMake. Signed-off-by: Zhaoxiang Jin <[email protected]>
Update hal_nxp to mcux sdk 25.06.00. Signed-off-by: Zhaoxiang Jin <[email protected]>
Now use the 5-parameter function "PINT_PinInterruptConfig" deprecated in MCUX SDK, need to add compile definition 'PINT_USE_LEGACY_CALBACK' to make intc_nxp_pint compatible with updated 'fsl_pint' driver. Signed-off-by: Zhaoxiang Jin <[email protected]>
1. Add core_id for RT685 HIFI4 core, this variable is used in MCUX SDK cmake. 2. Set cmake variables 'CONFIG_MCUX_COMPONENT_driver.smartdma_mcxn' and 'CONFIG_MCUX_COMPONENT_driver.smartdma_rt500' to "ON" as these variables control the loading of source files in the latest driver CMakeList.txt. Signed-off-by: Zhaoxiang Jin <[email protected]>
1. Renamed MCXA166 to MCXA346. 2. NXP frdm_mcxa166 is renamed to frdm_mcxa346, add this information to migration-guide-4.3.rst. Signed-off-by: Zhaoxiang Jin <[email protected]>
1. Renamed MCXA276 to MCXA266 2. NXP frdm_mcxa276 is renamed to frdm_mcxa266, add this information to migration-guide-4.3.rst. Signed-off-by: Peter Wang <[email protected]>
c112334
to
5c359d4
Compare
Update:
|
Move board specific files (dcd, flash_config, etc.) from nxp hal repo to zephyr repo. Signed-off-by: Zhaoxiang Jin <[email protected]>
5c359d4
to
9e64dd7
Compare
|
@ZhaoxiangJin please address the compliance failures |
Fix is on going, but there are a lot of compliance issues that need to be resolved, I need more time to fix them... |
Hi @dleach02 , the compliance issue is because we are moving the board specific dcd.c, flexspi_nor_config.c to zephyr board folder. There are many coding style issue in these files. |
Update hal nxp to mcux sdk 25.06.00.